I will take a closer look in the upcomming days! :) Been a bit busy now but it's on my todo list! :)

Hey @amacado,

I really appreciate your feedback :)

I understand the delay and I am not bothered by it. In fact, I think I might be in the same boat as you in the next few months. I also would like to thank you for going over my codes and discussing things with me. It really helps having a second person do a code review on something like this.

So as always, I'll address your points one by one:

Can the .pyc (py-cache) scripts be removed? I don't think they are required in the repo, or are they? (f.e. .github/scripts/build_assets/pycache/PathResolverAction.cpython-38.pyc). We should also add them to .gitignore, since they were added and commited by git git add . command running in the action.

The cache is not essential so I can definitely do that. The IDE that I use would hide this folder while I work so I sometimes forget that it exists.

.github/scripts/build_assets/geckodriver.exe should be documented (version, source,..) maybe add a readme?

That sounds good to me. I'll add a README about it.

As we figured out in our discussion it would be good to run our gulp task gulp default (for combining the colors/alias and creating a minified version) after finishing the iconmoon job. Maybe you could introduce this?

This is on my TODO list. I'm currently working on adding the color and aliases attributes to the devicon.json. Once I'm done with it, I will start working on the gulp task and add it to our workflow.

Is there a reason to include the icon changes to haskell in this branch? I would suggest separate this to keep things clean.

Are you referring to the fact that the haskell folder is moved in to the fonts folder? If you are, I did it just to clean the directory up. I was confused why the folder stayed in the root directory for so long in the first place. If there's a reason for it, I can move it back.

In your code-comments you often write icomoon_test.json and devicon_test.json is this intented?

That was not intended. During testing, I would rename the original files to icomoon_test.json and devicon_test.json. My IDE would then automatically update all the references to these files, which included docs. I thought I fixed all of them so thanks for spotting it.

I hope that answered all your questions. I'll start working on your suggestions and I'll let you know when I'm done.

Are you referring to the fact that the haskell folder is moved in to the fonts folder? If you are, I did it just to clean the directory up. I was confused why the folder stayed in the root directory for so long in the first place. If there's a reason for it, I can move it back.

ah! Now I understand. But again, I would suggest to track this issue 274 in a separated pull request, I will open one to keep our directory structure clean and not mixin this with our build script.
Update: I fixed the haskell icon structure in #275 and merged the updated master back into this branch. Since I did not want to force push your branch I created a pull request to this branch including the current master branch merge: #276. This fill resolve the conflicts which are currently pointed out in this branch:

I hope that answered all your questions. I'll start working on your suggestions and I'll let you know when I'm done.

looking forward to review your changes! :) happy coding!

I am fine with the changes that you introduced. However, there's one small change: the alias attribute would be aliases instead. This is only a semantic change and would not affect functionality.

interface NewDeviconObject extends DeviconObject {
  "color": string;  // color for the colored version
  "aliases": [
                  {
                       "base": string;
                       "alias": string;
                  },
                  {
                       "base": string;
                       "alias": string;
                  }
              ]
}